Skip to content

Stable 26.8 Backport of #131001 - Reuse the GCM cipher context between rows in encrypt/decrypt - #2902

Merged
zvonand merged 1 commit into
stable-26.8from
backports/stable-26.8/131001
Nov 19, 2026
Merged

zvonand merged 1 commit into
stable-26.8from
backports/stable-26.8/131001

Conversation

@blau-ai

@blau-ai blau-ai commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Improve performance of the encrypt, decrypt and tryDecrypt functions in AES-GCM modes by up to 27x with many threads. (ClickHouse#131001 by @mkmkme)

Documentation entry for user-facing changes

...

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • CAS (content-addressed storage; Antalya only)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

Reuse the GCM cipher context between rows in encrypt/decrypt
@github-actions

Copy link
Copy Markdown

Workflow [PR], commit [8b9789c]

@zvonand

zvonand commented Nov 19, 2026

Copy link
Copy Markdown
Member

@blau-ai

@blau-ai

blau-ai commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator Author

CI triage for 8b9789c

5 failing checks. None are caused by this PR. 1 is a test-infra problem that is already fixed on stable-26.8, 2 are base-image CVEs, and 1 is the usual DCO failure on backports. PR is just the aggregate gate.

The PR changes only src/Functions/FunctionsAES.h, one perf test and one stateless test (04337_encrypt_decrypt_block_modes). All stateless, unit, build, regression and integration shards that ran passed, apart from the one below.

Check Classification Caused by this PR?
Integration tests (amd_asan_ubsan, db disk, old analyzer, 1/8): 40/857 failed Test infra: the python-bottle:latest mock image tag No. Fixed on base by #2880
GrypeScanKeeper / GrypeScanServer (-alpine) New CVEs in the base image No
DCO Upstream merge commit has no sign-off No

1. Integration tests (amd_asan_ubsan, db disk, old analyzer, 1/8): Failures 40/857

All 40 failures come from two modules, failing during module setup:

  • test_database_glue/test.py: 33 tests
  • test_storage_s3/test_sts.py: 7 tests

Both fail the same way: the STS mock container never starts.

E   Exception: Timed out while waiting for instance `sts.us-east-1.amazonaws.com' with ip address 172.16.3.10 to start. Container status: running, logs: ...
E   bash: line 1: /usr/bin/clickhouse: cannot execute: required file not found
  • Cause: the PR head still starts the mock with image="altinityinfra/python-bottle", tag="latest". :latest is pushed one architecture at a time, so it often holds an image for the wrong architecture, and the container can't execute.
  • Already fixed on base: Antalya 26.8: Use the pinned python-bottle tag in integration tests #2880 (merged into stable-26.8 via Stable 26.8 - Port CI fixes from Antalya-26.8 (#2880, #2887, #2877) #2921 at 0ecd9aaf87e) switches both modules to tag=os.environ.get("DOCKER_PYTHON_BOTTLE_TAG", "latest"). Between this PR's head and current origin/stable-26.8, the only tests/integration changes are that one line in test_database_glue/test.py and in test_storage_s3/test_sts.py.
  • Not related to this PR: the PR doesn't touch S3, Glue, STS or the integration harness.
  • Next step: merge or rebase on the current stable-26.8 (or just re-run CI after updating the branch). These two modules should then pass.

2. Grype scans: clickhouse-keeper and clickhouse-server …-alpine ("4 high/critical vulnerabilities")

3. DCO


Bottom line: nothing to fix in the backport itself. Update the branch from stable-26.8 to pick up the python-bottle tag fix, then re-run CI. Note that this CI config excluded the arm, tsan and msan jobs, so the GCM change has had no sanitizer coverage beyond ASan/UBSan here.

@zvonand zvonand added the verified Approved for release label Nov 19, 2026
@zvonand
zvonand merged commit ded3a1a into stable-26.8 Nov 19, 2026
269 of 277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backport stable verified Approved for release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants